Add support for Bootloader Nack

CMUAbstract / tab

TAB reference implementations, examples, and documentation

Other

0 stars 0 forks source link

Add support for Bootloader Nack #9

Closed mablem8 closed 1 year ago

mablem8 commented 1 year ago

Add a description of Bootloader Nack to DOCUMENTATION.md
Add an implementation of Bootloader Nack to c-implementation/tab.c
Add an implementation of Bootloader Nack to python-implementation/tab.py
Add testing of Bootloader Nack in python-examples/tx/tx_example.py
Test support for Bootloader Nack with c-examples/cdh-monolithic and python-examples/tx

ChadTaylor17 commented 1 year ago

Commit: 1062e8a04e069def9f2c32c677e354f074cd6743

Tested successfully: txcmd: bootloader_nack hw_id:0x1234 msg_id:0x0006 src:gnd dst:cdh reply: common_nack hw_id:0x1234 msg_id:0x0006 src:cdh dst:gnd

mablem8 commented 1 year ago

For future posts, link to the changes that address each issue bullet:

✅ A description of Bootloader Nack has been added here
- ❌ The description has not been linked in the Overview
- The bootloader negative-acknowledgement command is used as a bootloader reply indicating failure
✅ An implementation of Bootloader Nack has been added to tab.c
✅ An implementation of Bootloader Nack has been added to tab.py
✅ Adds testing of Bootloader Nack in tx_example.py
I will replicate the test after the above updates have been made

ChadTaylor17 commented 1 year ago

Commit: 51ec4fbfae109575a13017a01068f05b4245f500

mablem8 commented 1 year ago

This commit looks good!

When submitting an Issue fix, use the following format:

A description of Bootloader Nack has been added here
An implementation of Bootloader Nack has been added to tab.c
An implementation of Bootloader Nack has been added to tab.py
Testing of Bootloader Nack has been added to tx_example.py
Test output for Bootloader Nack:

txcmd: bootloader_nack hw_id:0x1234 msg_id:0x0006 src:gnd dst:cdh
reply: common_nack hw_id:0x1234 msg_id:0x0006 src:cdh dst:gnd