CMUEberlyCenter / eberly-docuscope-wa

Other
0 stars 0 forks source link

"low hanging fruit" cosmetic fixes (mostly) #76

Open sugurui opened 4 days ago

sugurui commented 4 days ago

Attached annotated screenshots show various cosmetic adjustments that are relatively easy to make. But, I’ve commented on a few things that may require extra time and/or non-cosmetic issues; so you may or may not address these depending on the effort level to address them.

The higher priority items are about spaces, dimensions and few colors. I did not provide exact sizes/dimensions but if you are not sure, please ask me or refer to the screenshots I provided earlier.

Comments on the visualizations are mostly low priority, but if it’s possible to (a) change the little circle smaller, and (b) reduce the font size of the text in the legend (to fit each label in a single line), that’d improve the look & feel.

I will also add this PDF to the GitHub Issues, so that you can track it.

UI Comments (2024.09.20).pdf

Ringenberg commented 22 hours ago

Page 1 (initial)

Ringenberg commented 21 hours ago

Focus frame around editor should not be removed for accessibility reasons: https://www.a11yproject.com/posts/never-remove-css-outlines/#:%7E:text=Using%20the%20CSS%20rule%20%3Afocus,with%20the%20link%20or%20control

Ringenberg commented 21 hours ago

Underlining for sentence density should be used for sentence text view with parts of speech decorations. Screenshot 2024-09-23 102755

Ringenberg commented 21 hours ago

As it is currently very easy to loose the user selected text, the user selected text box should be kept.

Ringenberg commented 3 hours ago

Tab decorators should be returned as bolding is not enough of an indicator of state and what those buttons control.