Treat pointer types like desc

[AutonomicPerfectionist]

Is this pull request associated with an issue(s)? Fixes #96

Description This PR adds support for pointer types in signatures and type assertions by treating them like they are desc.

TODOs

• [x] Add tests for cpp_is_type() for pointer types
• [x] Restrict cpp_is_type pointer type detection, right now it's a simple regex
• [x] Update documentation

[AutonomicPerfectionist]

I think this is ready for review, I haven't restricted the is_type check but let me know if that would be desirable

[ryanmrichard]

To be clear, when you say restricting the is_type check, are you referring to making sure that the the say a bool* actually points to a bool rather than pointing to say a list?

[AutonomicPerfectionist]

Yeah that's what I mean

[ryanmrichard]

Yeah, I'm fine punting on that for now.

[AutonomicPerfectionist]

Sounds good. I did see a couple diagrams in the documentation, I didn't modify any of them but should we? I think the only relevant one is the type relations diagram

[AutonomicPerfectionist]

How would a pointer to a pointer be handled in this implementation (for example, list**)?

I did think of that and it should work, but I'll definitely add tests and documentation for it

[ryanmrichard]

Sounds good. I did see a couple diagrams in the documentation, I didn't modify any of them but should we? I think the only relevant one is the type relations diagram

It's be good to keep the documentation in synch or at least open an issue about it.

[AutonomicPerfectionist]

@zachcran is there a source file somewhere for the type_relations.png diagram?

[ryanmrichard]

@zachcran is there a source file somewhere for the type_relations.png diagram?

Usually the diagrams contain the source as metadata. So you should just be able to open the diagram in the appropriate program. That particular diagram looks like it was drawn with https://www.drawio.com/

[AutonomicPerfectionist]

Hmmm, tried opening it in drawio.com and it said it wasn't a diagram file... I checked the true file type and it is indeed a png file. Checked metadata with ImageMagick and I don't see anything that could be interpreted as the diagram source

[ryanmrichard]

It's possible I forgot to click the "embed diagram" (or whatever they call the option) upon saving. I guess that means the image will probably need to be remade. Don't worry about doing that unless you really want to (and if you do I recommend using Excalidraw, since we've been using that instead of draw.io for some time now).

[AutonomicPerfectionist]

Sounds good, for now, I just added a small blurb to the RST file where the diagram is shown explaining the relationships for pointers

[github-actions[bot]]

🚀 [bumpr] Bumped! New version:v0.0.7 Changes:v0.0.6...v0.0.7