Closed ryanmrichard closed 8 months ago
Some notes on the front matter:
CMakePP: An object-oriented extension to CMake
?By other comment is that the code snippets are a bit small in the PDF
@blakemulnix and @AutonomicPerfectionist we're pretty close to being ready to submit this. So now's your chance to read and comment on the paper before we submit it. The paper is pretty short (only four pages, one page is references and another is code snippets) and is available in a zip file here.
If you do read it, please let us know if you have any comments or suggestions. If you don't want to read it that's fine too. Either way, please let us know that you are okay submitting the paper.
@ryanmrichard I read through the paper and it looks good to me. I'm okay with submitting it as-is
@AutonomicPerfectionist Thanks!
Looks good to me!
@blakemulnix and @AutonomicPerfectionist do either of you have ORCiD? You don't need to have one, but if you have one I want to make sure it gets on the paper.
I do not have ORCiD.
I do not either
@AutonomicPerfectionist the tests are now failing for this branch. Is it possible we need to update something owing to new CMakeTest changes?
@AutonomicPerfectionist the tests are now failing for this branch. Is it possible we need to update something owing to new CMakeTest changes?
I took a look, it seems to be the name of a test is being interpreted as a type, causing the overload checks to fail. I'll look into it further and see what needs to be done
@AutonomicPerfectionist for now I'm just going to pin the version of CMakeTest back a commit (arguably we should have been pining the version anyways), that'll make the tests pass again. Longer term we need to figure out if we want to allow test names which are recognized as types (I'm inclined to say yes as it arose quite naturally here).
All proofs are available here. Please let me know as soon as possible (ideally in the next couple of days) if there's anything you want to change.
@ryanmrichard Should this PR be closed now?
This PR should NOT be merged into master.
The purpose of this PR is to prepare a submission to JOSS. The PR itself serves as a way for the team to communicate and collaborate on the paper contents. and, IIRC, JOSS is going to require us to have a PR anyways.