search

CMakePP / CMakeTest

A unit-testing framework for CMake functions
https://cmakepp.github.io/CMakeTest/
Apache License 2.0
10 stars 6 forks source link

Fix docs badge on README.rst #86

Closed AutonomicPerfectionist closed 1 year ago

AutonomicPerfectionist commented 1 year ago

Is this pull request associated with an issue(s)? Fixes #84

Description This just changes the badge URL in the README.rst to the correct one for the docs action.

Note Apparently, those URLs are based on the name of the workflow, so if we change the name we'd need to change these URLs again, even if the workflow filename remains the same

AutonomicPerfectionist commented 1 year ago

Yep that makes sense, I'll get that changed as soon as possible

AutonomicPerfectionist commented 1 year ago

I removed the query string but I decided to look at the documentation to see why it was there in the first place. Curiously, it seems there are two different URL schemes for badges, the documentation here suggests to use the .../actions/workflows/<filename>/badge.svg URL and supports the query string, while I can't find any documentation at all on the URL scheme we're using (without the actions prefix and using the name of the workflow instead of the filename). But both display the "no status" badge, it could be related to the failed docs action but I would've thought it would say failed then and it wouldn't matter whether we had a query string...