search

CMakePP / CMinx

Generates API documentation for CMake functions and macros
https://cmakepp.github.io/CMinx/
Apache License 2.0
14 stars 5 forks source link

Fixed 'List' type annotations for Python 3.8 #101

Closed zachcran closed 2 years ago

zachcran commented 2 years ago

Description Fixes type annotations incompatible with Python 3.8. Specifically, list[<type>] is incompatible and gives a TypeError: 'type' object is not subscriptable error, while List[<type>] works if you import from typing import List.

codecov[bot] commented 2 years ago

Codecov Report

Merging #101 (7924ea3) into master (08375a3) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   95.99%   96.00%           
=======================================
  Files           6        6           
  Lines         799      800    +1     
=======================================
+ Hits          767      768    +1     
  Misses         32       32
Flag Coverage Δ
unittests 96.00% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cminx/__init__.py 93.24% <100.00%> (+0.04%) :arrow_up:
cminx/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08375a3...7924ea3. Read the comment docs.

ryanmrichard commented 2 years ago

🚀 [bumpr] Bumped! New version:v0.1.2 Changes:v0.1.1...v0.1.2