AutonomicPerfectionist commented 2 years ago

This pull request adds a few tests for the CMake interface. It also crucially adds the ability to generate a package config file during the configure step, allowing the location of the virtual environment to be found if needed, and the constructed binary to be found as well. This fixes #49. Also fixes a previously unknown bug where the CMake interface wasn't using recursive mode for a directory input. Should probably add an explicit option instead of implying it through whether the specified input is a directory or not.

ryanmrichard commented 2 years ago

Sorry I took so long to look at this.

codecov[bot] commented 2 years ago

Codecov Report

Merging #50 (a5fc640) into master (d544b42) will increase coverage by 85.59%. The diff coverage is 96.42%.

@@             Coverage Diff             @@
##           master      #50       +/-   ##
===========================================
+ Coverage        0   85.59%   +85.59%     
===========================================
  Files           0        9        +9     
  Lines           0      951      +951     
===========================================
+ Hits            0      814      +814     
- Misses          0      137      +137

Flag	Coverage Δ
unittests	`85.59% <96.42%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cminx/rstwriter.py	`98.19% <ø> (ø)`
cminx/__init__.py	`89.74% <92.85%> (ø)`
cminx/documenter.py	`100.00% <100.00%> (ø)`
cminx/parser/aggregator.py	`89.69% <100.00%> (ø)`
cminx/parser/CMakeListener.py	`84.00% <0.00%> (ø)`
cminx/parser/__init__.py	`100.00% <0.00%> (ø)`
cminx/parser/CMakeLexer.py	`100.00% <0.00%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ae2510...a5fc640. Read the comment docs.

CMakePP / CMinx

Add CMake tests, add cmake package config file #50

Codecov Report