CMakePP / CMinx

Generates API documentation for CMake functions and macros
https://cmakepp.github.io/CMinx/
Apache License 2.0
14 stars 5 forks source link

Coverage fix #53

Closed AutonomicPerfectionist closed 2 years ago

AutonomicPerfectionist commented 2 years ago

This pull request should hopefully fix #46 as well as switch us from using coverage to run tests to PyTest. This should hopefully result in failed tests failing the entire action, instead of errors being quietly accepted. Using nektos/act locally showed that this Action was successful, however there are inconsistencies between it and actual Github Actions.

codecov[bot] commented 2 years ago

Codecov Report

Merging #53 (03e62f5) into master (d544b42) will increase coverage by 85.24%. The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #53       +/-   ##
===========================================
+ Coverage        0   85.24%   +85.24%     
===========================================
  Files           0        9        +9     
  Lines           0      942      +942     
===========================================
+ Hits            0      803      +803     
- Misses          0      139      +139     
Flag Coverage Δ
unittests 85.24% <92.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cminx/documenter.py 100.00% <ø> (ø)
cminx/rstwriter.py 98.19% <ø> (ø)
cminx/__init__.py 89.74% <92.85%> (ø)
cminx/parser/aggregator.py 89.36% <0.00%> (ø)
cminx/parser/CMakeParser.py 69.00% <0.00%> (ø)
cminx/parser/__init__.py 100.00% <0.00%> (ø)
cminx/parser/CMakeVisitor.py 0.00% <0.00%> (ø)
cminx/parser/CMakeListener.py 84.00% <0.00%> (ø)
cminx/parser/CMakeLexer.py 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43d14e2...03e62f5. Read the comment docs.

ryanmrichard commented 2 years ago

Maybe it just takes a bit to update, but the badge on the README is still showing 0%. Clicking on the badge takes one to codecov's website where they're showing 80-something percent. So at the very least this PR fixed 99.9% of the issue