CMakePP / CMinx

Generates API documentation for CMake functions and macros
https://cmakepp.github.io/CMinx/
Apache License 2.0
14 stars 5 forks source link

Remove explicit runtime-tmpdir and move installation to install phase #60

Closed AutonomicPerfectionist closed 2 years ago

AutonomicPerfectionist commented 2 years ago

This PR removes the explicit --runtime-tmpdir option to PyInstaller, allowing it to extract to the system-specific tmp directory. It also moves the installation of the generated binary to the install phase rather than the build phase.

Fixes #59 and helps with #39

codecov[bot] commented 2 years ago

Codecov Report

Merging #60 (42cff93) into master (d544b42) will increase coverage by 85.65%. The diff coverage is 96.87%.

@@             Coverage Diff             @@
##           master      #60       +/-   ##
===========================================
+ Coverage        0   85.65%   +85.65%     
===========================================
  Files           0        9        +9     
  Lines           0      955      +955     
===========================================
+ Hits            0      818      +818     
- Misses          0      137      +137     
Flag Coverage Δ
unittests 85.65% <96.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cminx/__init__.py 89.74% <92.85%> (ø)
cminx/documenter.py 100.00% <100.00%> (ø)
cminx/parser/aggregator.py 89.89% <100.00%> (ø)
cminx/rstwriter.py 98.21% <100.00%> (ø)
cminx/parser/CMakeParser.py 69.64% <0.00%> (ø)
cminx/parser/CMakeLexer.py 100.00% <0.00%> (ø)
cminx/parser/CMakeListener.py 84.00% <0.00%> (ø)
cminx/parser/__init__.py 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5fd196...42cff93. Read the comment docs.