AutonomicPerfectionist commented 2 years ago

This pull request should cause the pip_install workflow to trigger on all pushes to master, which includes the merging of other PRs. Since that workflow triggers testing and coverage reports this should also fix #46. @ryanmrichard do we also want to run the add_licenses and cmake_install workflows on pushes to master or leave those as is?

codecov[bot] commented 2 years ago

Codecov Report

Merging #61 (c2cda8d) into master (d544b42) will increase coverage by 85.65%. The diff coverage is 96.87%.

@@             Coverage Diff             @@
##           master      #61       +/-   ##
===========================================
+ Coverage        0   85.65%   +85.65%     
===========================================
  Files           0        9        +9     
  Lines           0      955      +955     
===========================================
+ Hits            0      818      +818     
- Misses          0      137      +137

Flag	Coverage Δ
unittests	`85.65% <96.87%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cminx/__init__.py	`89.74% <92.85%> (ø)`
cminx/documenter.py	`100.00% <100.00%> (ø)`
cminx/parser/aggregator.py	`89.89% <100.00%> (ø)`
cminx/rstwriter.py	`98.21% <100.00%> (ø)`
cminx/parser/__init__.py	`100.00% <0.00%> (ø)`
cminx/parser/CMakeVisitor.py	`0.00% <0.00%> (ø)`
cminx/parser/CMakeListener.py	`84.00% <0.00%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 508569b...c2cda8d. Read the comment docs.

ryanmrichard commented 2 years ago

I think just running the pip install workflow should be fine. In theory, if the workflows worked on the PRs they should also work on master after the merge.

CMakePP / CMinx

Make pip_install workflow trigger on pushes to master #61

Codecov Report