search

CMakePP / CMinx

Generates API documentation for CMake functions and macros
https://cmakepp.github.io/CMinx/
Apache License 2.0
14 stars 5 forks source link

Update dependencies in requirements.txt #64

Closed ni-fgenois closed 2 years ago

ni-fgenois commented 2 years ago

These dependencies should work on python 3.10; I also loosen the dependencies constraints using the ~= operator.

This command now installs CMinx successfully on 3.10 : pip install git+https://github.com/ni-fgenois/CMinx.git@feature/update-deps

AutonomicPerfectionist commented 2 years ago

Already taken care of in #63

ryanmrichard commented 2 years ago

@ni-fgenois Let me start by thanking for your contribution!!! Sorry it took me so long to respond, but I was traveling for the long weekend.

My guess is your PR is failing because you changed the Antlr version (the error in the CI looks like it's coming from Antlr). It's up to you, but since @AutonomicPerfectionist's PR (#63) already passes CI, you may want to see if that PR fixes your issues before trying to debug this one.

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

ni-fgenois commented 2 years ago

Oh true, yeah, I'll close this PR.

I still think you should consider loosely pinning your dependencies to avoid such a problem in the future.

Thanks for maintaining this project!