codecov[bot]
commented
2 years ago Codecov Report
Merging #98 (3edb1a4) into master (c796532) will increase coverage by
0.03%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 96.00% 96.03% +0.03%
==========================================
Files 6 6
Lines 800 807 +7
==========================================
+ Hits 768 775 +7
Misses 32 32 | Flag | Coverage Δ | |
|---|---|---|
| unittests | 96.03% <100.00%> (+0.03%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/cminx/config.py | 100.00% <ø> (ø) |
|
| src/cminx/documenter.py | 99.11% <ø> (ø) |
|
| src/cminx/parser/__init__.py | 100.00% <ø> (ø) |
|
| src/cminx/parser/aggregator.py | 93.22% <ø> (ø) |
|
| src/cminx/rstwriter.py | 98.26% <ø> (ø) |
|
| src/cminx/__init__.py | 93.24% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
ryanmrichard
AutonomicPerfectionist
Is this pull request associated with an issue(s)? Fixes #69
Description To make this all work I relied heavily on this tutorial.
This PR makes it so that we are able to make PyPI packages from CMinx (a forthcoming PR will automate the process). To accomplish this I refactored CMinx's source into the
srcdirectory. Based on the tutorials I found online, it's strongly recommended to use such a layout to ensure that the PyPI package is tested (with this setup you have to basically install the package locally to test it). This required updating paths throughout the rest of the project.This PR also overhauls the CMake build of CMinx. Upon moving the source to
srcI realized that our CMake build was quite different from the Python build. Ultimately, the CMake build is still different (we still use PyInstaller to make a self-contained executable), but now our CMake build uses the editable install of the Python build to seed PyInstaller. I also updated the packaging files so that they used the installed version of CMinx (the version in thestagedirectory while unit testing, and the version in the install directory after installation)