CMertens / protobuf-net

Automatically exported from code.google.com/p/protobuf-net
Other
0 stars 0 forks source link

Enum underscores and -p:fixCase #397

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. Define a enum with underscores at some of its fields. Define a message with 
a reference to the enum type (see attached Test.proto).
2. Generate proto proxies with the -p:fixCase option: protogen -i:Test.proto 
-o:Test.cs -p:fixCase (Generated Test.cs is also attached.)

What is the expected output? What do you see instead?

Generated source file is expected to compile, but it's not. The generated enum 
constants are missing original underscores, but references at the other 
messages still use its original names.

What version of the product are you using? On what operating system?

r640

Please provide any additional information below.

(a bit off topic)

It would be great for generated enums to follow general naming conventions:

"Names of enumeration types (also called enums) in general should follow the 
standard type-naming rules (PascalCasing, etc.)." 
(http://msdn.microsoft.com/en-us/library/ms229040.aspx)

Original issue reported on code.google.com by jenyapis...@gmail.com on 5 Jul 2013 at 6:25

Attachments: