small bug detected in scattering matrix computation

CNES / RadiativeTransferCode-OSOAA

Ocean Successive Orders with Atmosphere - Advanced (OSOAA) : Accurate computation of the radiative tranfer into the Ocean-Atmosphere system including polarisation, coupling terms, and the agitated surface.

GNU General Public License v2.0

30 stars 12 forks source link

small bug detected in scattering matrix computation #4

Closed Tristanovsk closed 4 years ago

Tristanovsk commented 5 years ago

I just noticed that XMU(0) is not initialized to zero in OSOAA_HYDROSOLS.F and OSOAA_AROSOLS.F. This can yield erroneous values for the scattering matrices at 90° scattering angle (it was the case for me for hydrosols). fix: add

! initialize XMU for index 0
      XMU(0)=0.

in OSOAA_AROSOLS.F at row 786 in OSOAA_HYDROSOLS.F at row 625

CDesj commented 4 years ago

Thank you for your comment. Our verification shows that there is no bug in the model. It seems that the specific configuration of your run is not supposed to be taken into account by the model. We invite you to contact directly the PI-scientists of the OSOAA model if you need more explanations