search

CNES / ccsdsmo-malc-stubgenerator

Stub Generator for CCSDS MAL C API
https://cnes.github.io/ccsdsmo-malc
MIT License
3 stars 2 forks source link

Generated functions for PUBLISH-NOTIFY use incorrect type #7

Closed gbonnefille closed 6 years ago

gbonnefille commented 7 years ago

The generated functions use directly the type described in the XML description.

But the CCSDS 521.0-B-2 states:

A PUBLISH message body shall contain an UpdateHeader list followed by a list of
each type defined in the top-level PUBSUB template. For example, a PUBSUB
operation defined using the types of [Boolean, Octet, MyComposite] will result in a
PUBLISH message with the body containing [List, List,
List, List].

The generated functions should use list version of the types described in the service.

gbonnefille commented 7 years ago

The code was quite ready for that and fix is simple/trivial: https://github.com/gbonnefille/stubgenerator_c/commit/78b6ad12716ed853b7451f08fd6ffc58498ec1f0