search

CNES / ccsdsmo-malc-stubgenerator

Stub Generator for CCSDS MAL C API
https://cnes.github.io/ccsdsmo-malc
MIT License
3 stars 2 forks source link

Data of the PUBSUB-NOTIFY are mandatory #8

Closed gbonnefille closed 6 years ago

gbonnefille commented 7 years ago

The helper functions generated to decode data of a PUBSUB-NOTIFY service operation was generated as optional, nullable. But the CCSDS 521.0-B-2 states in 3.4.2.4 that:

How the message body is actually encoded shall be dependent on the encoding technology used, but all message parts are expected to be supplied.

So, the generated function consumes incorrectly the bitfield in the MalSplitBinary.

gbonnefille commented 7 years ago

Fix proposed: https://github.com/gbonnefille/stubgenerator_c/commit/f255854bacb205d7ddaf7d855f5a77bbd7c5ab72