search

CNES / ccsdsmo-malc

CCSDS MO MAL C API
https://cnes.github.io/ccsdsmo-malc
MIT License
14 stars 4 forks source link

Values of attribute's tag #24

Closed gbonnefille closed 7 years ago

gbonnefille commented 7 years ago

The values used for the attribute tag is not compliant with CCSDS RECOMMENDED STANDARD FOR
MISSION OPERATIONS MESSAGE ABSTRACTION LAYER CCSDS 521.0-B-2.

It appears that they are all translated by one. For example, the blob tag is valued to 0 (zero) while it is expected to be 1 (one).

freyssin commented 7 years ago

If I refer to section 5.2.2 of the MAL/TCP specification it seems that it is correct: "5.2.2 The field ‘Attribute Tag’ shall be assigned with the short form part of the attribute minus 1 so that the tag starts from zero.".

gbonnefille commented 7 years ago

It seems there is an error in the decoding process of the attribute tag. See work in progress on https://github.com/gbonnefille/malc/tree/fix-attribute-tag

gbonnefille commented 7 years ago

Branch updated to revise the mal attribute tag enc/dec functions and to fix the decoding of mal_attribute_t.

gbonnefille commented 7 years ago

Fixed by https://github.com/ccsdsmo/malc/pull/25