search

CNMAT / CNMAT-Externs

CNMAT Max/MSP externals
Other
96 stars 11 forks source link

basic resonators~ lacks a help patch #107

Closed adrianfreed closed 6 years ago

adrianfreed commented 6 years ago

or it got moved somewhere???

adrianfreed commented 6 years ago

On reflection I prefer basic-resonators~ to be pulled from the repo and release. It is not owned by UC Regents or CNMAT and isn't required in the rest of the release. I will distribute it from my own github repo.

equilet commented 6 years ago

Hi @adrianfreed - thanks for contacting. basic-resonators~ has not been included in the release for some time. Someone has removed the downloadable zips/tarballs associated with prior releases or else I would link you to more examples. I am removing it from our build system and this repository regardless, and was planning on putting it into a deprecated area.

If you would like to maintain it, that would be great! Thanks for the offer - please let me know in a PM what, if anything, I can do to assist.

adrianfreed commented 6 years ago

Thanks for clarifications. I am not sure what this is about: "Someone has removed the downloadable zips/tarballs associated with prior releases”

Are you referring to the ones that were served from the web site that was taken down (before github)? Presumably these are on the archive disk for that site.

I am not offering to maintain basic-resonators~, but since it is my code it is better I host it on my own github.

In general it is a good idea to minimize 3rd party source in the CNMAT repositories. It produces IP entanglements and gets stale without a discipline to update and test from the source repo. This is already a headache for you with FFTW and GSL. Their licenses seem to contaminate and be in conflict with the UC license for the externals.

If you notice any more of my code with my personal copyright notice, please let me know. I remembering pulling some old code and putting it into resdisplay, for example.

On Mar 29, 2018, at 13:11, Jeffrey Lubow notifications@github.com wrote:

Hi @adrianfreed - thanks for contacting. basic-resonators~ has not been included in the release for some time. Someone has removed the downloadable zips/tarballs associated with prior releases or else I would link you to more examples. I am removing it from our build system and this repository regardless, and was planning on putting it into a deprecated area.

If you would like to maintain it, that would be great! Thanks for the offer - please let me know in a PM what, if anything, I can do to assist.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

equilet commented 6 years ago

OK, will do

equilet commented 6 years ago

Yes, I have reviewed the processes by which we should evaluate 3rd party inclusion internally, campus wide, and for distributions that are public with EECS. They are all very different. We finally have solid answers about best practices there, which is relieving. There will be some forthcoming updates along these lines.

equilet commented 6 years ago

I am not offering to maintain basic-resonators~, but since it is my code it is better I host it on my own github.

Sounds good.