search

CNMAT / CNMAT-Externs

CNMAT Max/MSP externals
Other
96 stars 11 forks source link

rbfi: compat mode, inactive attrs and messages #96

Closed equilet closed 6 years ago

equilet commented 6 years ago

I'm looking around at all the patches I have on my machine throughout the years and I cannot find anything with the compatmode attr used. If this is something that we can remove, we should, because I don't think it would have been used outside of the context of pedagogical patches at UCB.

Does anyone have thoughts on or experiences with this?

adrianfreed commented 6 years ago

don’t sweat the small stuff.

How are you all gonna test the hell out of the new recompiled bits before packaging things up?

On Jan 12, 2018, at 20:32, Jeffrey Lubow notifications@github.com wrote:

I'm looking around at all the patches I have on my machine throughout the years and I cannot find anything with the compatmode attr used. If this is something that we can remove, we should, because I don't think it would have been used outside of the context of pedagogical patches at UCB.

Does anyone have thoughts on or experiences with this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

equilet commented 6 years ago

Thanks Adrian - that's sage advice. I'm mainly just trying to tally everything that I find in here and move on as necessary. You'll note that what I deem important issues are compiled into the release milestone. :)

equilet commented 6 years ago

Here are the attrs and messages that I believe to be inactive:

  1. bang
  2. list
  3. labelcolor
  4. outputmode
  5. pointcolor
  6. selectedcolor
  7. spaces (spaces seems active but maybe something that you would never want the user to edit?)
adrianfreed commented 6 years ago

hmmm I can imagine uses for most of these. Are some left over from the JS RBFI work John?

On Jan 13, 2018, at 17:47, Jeffrey Lubow notifications@github.com wrote:

Here are the attrs and messages that I believe to be inactive:

• bang • list • labelcolor • outputmode • pointcolor • selectedcolor • spaces (spaces seems active but maybe something that you would never want the user to edit?) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

maccallum commented 6 years ago

I can’t say for certain why those seem to be inactive, but I can say that the design of the object changed quite a lot in the early days of that implementation, and I remember just leaving bits of code in there assuming that they’d be needed as the design continued to change. You can obviously just remove functions that have no body like rbfi_bang(), but like Adrian said, don’t sweat the small stuff.

On Jan 14, 2018, at 4:12 AM, Adrian Freed notifications@github.com wrote:

hmmm I can imagine uses for most of these. Are some left over from the JS RBFI work John?

On Jan 13, 2018, at 17:47, Jeffrey Lubow notifications@github.com wrote:

Here are the attrs and messages that I believe to be inactive:

• bang • list • labelcolor • outputmode • pointcolor • selectedcolor • spaces (spaces seems active but maybe something that you would never want the user to edit?) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CNMAT/CNMAT-Externs/issues/96#issuecomment-357485446, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjjdQOTYzBtT8g1zLduUvGGnTBVHdAsks5tKXChgaJpZM4RdGXN.