Closed EdmundCampion closed 9 years ago
Did you want this to apply to the inputs, outputs, or both?
I think both is a good idea -- as long as the there is a reasonable and fixed default on both. Then the ceiling can be raised from the "advanced settings" window -- and patch should remember the last settings in user preset.
For the default, go ahead and open the upper range some on both input and output.
OK, give pieceplayer-CS.maxpat
a spin. LMK if there is anything wrong there – If it looks good, I can update the CS-R
version. Note that gain is now specified in dB, which will make it easier to modify in the future. Also note that I opted for a static ceiling (+6dB) as I'd argue that this should be handled either by preparing files or by outboard gear when in rehearsals.
"I'd argue that this should be handled either by preparing files or by outboard gear when in rehearsals."
That is the problem as folks use the patch without outboard gear --
Got it. Will add a calibration parameter.
@EdmundCampion can you test this? It's checked in at this point and seems to be working fine here.
OK - looks like Ed's features are in place. Closing this out for now - if needed, we can reopen later or start another issue in the event that other features are needed.
The gain ceiling on the Depot/pieceplayers are still set too low. Solution is to add a range setting (upper end gain) in the patcher called advanced_settings. Then set the default of that range setting to a value that has much more head room then we currently have. Be sure that the upper range is posted in the advanced_settings (i.e. represents the current default value). Then limit the maximum gain to some number to avoid people putting in outrageous numbers --