search

CNMAT / OSC

OSC: Arduino and Teensy implementation of OSC encoding
cnmat.berkeley.edu/oscuino
Other
744 stars 138 forks source link

OSCData doesn't compile on Galileo #39

Open tambien opened 8 years ago

tambien commented 8 years ago

The fix is seems pretty easy, we just need to find the right ifdef for the Galileo (and probably also the Intel Edison) for this line (and the definition in the cpp file). This is probably because the ints are int_32 on these platforms, so it grumbles that there is a redefinition.

Maybe, is there a case for just getting rid of the int OSCData type constructor and just keeping int_16 and int_32? Moving forward there are going to be more 32bit platforms so that ifndef is probably going to keep growing. But i'm not sure right now if we would break anything if we removed the normal int constructor.

adrianfreed commented 8 years ago

can we do some clever ifdefs with #if sizeof(int)!=sizeof(int_32)

tambien commented 8 years ago

I don't think we can use sizeof in the preprocessor. (stack overflow)

adrianfreed commented 6 years ago

STM32 is producing this problem too.