search

CNMAT / OSC

OSC: Arduino and Teensy implementation of OSC encoding
cnmat.berkeley.edu/oscuino
Other
744 stars 138 forks source link

OSCMessage::empty() is missing return statement #51

Closed j-be closed 6 years ago

j-be commented 8 years ago

I think empty() is supposed to return *this, but it doesn't.

I'm not a C++ pro, so I'm not sure if I'm misinterpreting here or if it is a bug...

bakercp commented 6 years ago

This appears to be fixed now?

https://github.com/CNMAT/OSC/blob/master/OSCMessage.cpp#L84-L100

j-be commented 6 years ago

Yes, seems to have been fixed with commit 6922531f9d58bdfecf0bb8f08438a515801e852a.

Hence, I'm closing it.