COAST-Lab / c3po

Coastal Conductivity Communication Probe
0 stars 2 forks source link

Create a circuit diagram #5

Closed BentleySettin closed 5 months ago

SUPScientist commented 5 months ago

When opening an issue, try to give a little more detail about what the issue pertains to. In this case, not a huge deal since it was meant to create a sort of to-do list, but a good idea in general.

When closing an issue, link a closing message to a particular commit and/or file. In this case, put a link to this file: https://github.com/TinyCamML/ConductivitySensor/blob/main/Circuit%20Diagram/Initial%20Diagram.

Also recall the conversation from last year where Evan reminded you to always include file suffixes or file extensions. In this case, I imagine it's .png. You shouldn't need to do this manually if you follow the other requirements for pushing/pulling an entire repo rather than dragging and dropping individual files.

I'm reopening this. Close with comment when you link to the file and the file has its extension such that it can be opened.

BentleySettin commented 5 months ago

https://github.com/TinyCamML/ConductivitySensor/commit/b12e06759ead5c7d4913dcf5a0956130d9680d18

Here is the commit link! If I understand you correctly in this commit is the file suffix of .png

SUPScientist commented 5 months ago

Roger that. Both the closing comment and file extension look good—thanks for modifying.