COBREXA / AbstractFBCModels.jl

General interface for flux-based constrained metabolic models
Apache License 2.0
0 stars 1 forks source link

Implement RequiredInterfaces #2

Closed stelmo closed 1 year ago

stelmo commented 1 year ago

@exaexa do you like this? See here for the docs of this pkg: https://seelengrab.github.io/RequiredInterfaces.jl/stable/examples/basic.html

I can include some tests that make a fake module, implement the required interface, and check if it satisfies the requirements, but this feels a little circular...

exaexa commented 1 year ago

I guess it's OK, not much need to test stuff here... What does the error look like if you derive an incomplete model?

stelmo commented 1 year ago

It throws errors like this: https://seelengrab.github.io/RequiredInterfaces.jl/stable/examples/testing.html

stelmo commented 1 year ago

btw, it should be Nothing since you specify the type in the assert

stelmo commented 1 year ago

anyways, I would merge this, and edit as necessary