Add related OpenAIHub notebook to JFK dataset

CODAIT / exchange-metadata-converter

Basic conversion utility for YAML-based metadata descriptors

Apache License 2.0

1 stars 4 forks source link

Add related OpenAIHub notebook to JFK dataset #40

Closed ckadner closed 3 years ago

ckadner commented 3 years ago

@Tomcli added a notebook to OpenAIHub which we would like to discover and link during upload of the JFK dataset.

ptitzler commented 3 years ago

@ckadner

are we intentionally linking to a URL that is only accessible in the intranet?
should the URL be https://raw.github.ibm.com/OpenAIHub/openaihub/master/notebooks/samples/JFK-airport.yaml?token=AAAB74BIOZSQUX65DJHMEVK74JJKM? As is, the link points to an HTML/github page, which cannot be directly consumed Edit 1: same question for the URL value of source in the yaml file

Tomcli commented 3 years ago

@ckadner

are we intentionally linking to a URL that is only accessible in the intranet?

should the URL be https://raw.github.ibm.com/OpenAIHub/openaihub/master/notebooks/samples/JFK-airport.yaml?token=AAAB74BIOZSQUX65DJHMEVK74JJKM? As is, the link points to an HTML/github page, which cannot be directly consumed Edit 1: same question for the URL value of source in the yaml file

Adding the token will not help because it will expire in 24 hours. I think we are assuming the user of this asset can reach the url behind the firewall. Ideally we will change it to github.com once we open source openaihub early next year.

ckadner commented 3 years ago

@Tomcli -- I corrected the file in my latest commit

ckadner commented 3 years ago

@ptitzler -- we need the additional fields application and asset_id under related_assets to link assets in OpenAIHub

ckadner commented 3 years ago

The URL to the OpenAIHub hosted assets will turn into a publicly available URL soon, hopefully :-) I added it for reference only until then.

ckadner commented 3 years ago

Thanks @ptitzler for reviewing this PR so quickly