Review Feedback - Githubissues

CODAIT / exchange-metadata-converter

Basic conversion utility for YAML-based metadata descriptors

Apache License 2.0

1 stars 4 forks source link

Review Feedback #9

Open SSaishruthi opened 3 years ago

SSaishruthi commented 3 years ago

My review is in the perspective of usage in OpenAIHub and what end-users want in general.

Reference:

Existing OpenAIHub YAML
Dataset Landing Page

Comments:

Can we add details about the archive contents of the dataset?
Would like to see dataset coverage as well. Having this will set the expectation of the users right.

I used only JFK yaml for this review

@ptitzler

ptitzler commented 3 years ago

Can we add details about the archive contents of the dataset?

What are you looking for beyond what's already defined in https://github.com/CODAIT/exchange-metadata-converter/blob/main/dax-data-set-descriptors/jfk.yaml#L34-L46?

Would like to see dataset coverage as well. Having this will set the expectation of the users right.

Is https://github.ibm.com/CODAIT/DAX-OpenAIHub/blob/master/fpb.yaml#L22 something that could perhaps be included in the file description (e.g. https://github.com/CODAIT/exchange-metadata-converter/blob/main/dax-data-set-descriptors/lorem_ipsum.yaml#L36) or is the free form text meant to describe the entire data set?