search

CODAIT / magicat

🧙😺 magicat - Deep learning magic.. with the convenience of cat!
Apache License 2.0
26 stars 5 forks source link

use @codait/max-image-segmenter #6

Closed vabarbosa closed 5 years ago

vabarbosa commented 5 years ago

@kastentx here are the changes for using @codait/max-image-segmenter. let me if you run into any issues or have any questions or want additional changes. thanks.

kastentx commented 5 years ago

Looks good for the most part. The performance is great!

Could we squelch these messages though?

loading model...
model load: 42.425ms
running model...
model inference: 790.218ms
running model...
model inference: 760.138ms

I'm also getting this warning, but I think it might go away once we merge:

objc[1044]: Class GNotificationCenterDelegate is implemented in both /Users/nick/Code/MY_FORKS/magicat/node_modules/canvas/build/Release/libgio-2.0.0.dylib (0x108523578) and /Users/nick/Code/MY_FORKS/magicat/node_modules/@codait/max-image-segmenter/node_modules/canvas/build/Release/libgio-2.0.0.dylib (0x109782498). One of the two will be used. Which one is undefined.
vabarbosa commented 5 years ago

@kastentx good catch, i missed that. extraneous logging has been removed. thanks.