search

CODAIT / max-central-repo

Central Repository of Model Asset Exchange project. This repository contains information about the available models, current project status, contribution guidelines and supporting assets.
https://developer.ibm.com/exchanges/models/
84 stars 29 forks source link

Add support template #4

Closed xuhdev closed 4 years ago

SSaishruthi commented 4 years ago

@xuhdev Thanks.

  1. We already have a template for people to initiate discussion. Can you please add a section there?

Suggestion: Section name can be General Discussion. https://github.com/CODAIT/max-central-repo/blob/master/PULL_REQUEST_TEMPLATE.md

We can point them from main page

  1. This repo is dedicated to MAX. I am not sure if we are mixing MAX and DAX here. It is better to have separate as the structure will be different. I will initiate a conversation with Gabriela about the same. For now, can we just have MAX and not DAX?
xuhdev commented 4 years ago

@xuhdev Thanks.

1. We already have a template for people to initiate discussion. Can you please add a section there?

What do you mean?

Suggestion: Section name can be General Discussion. https://github.com/CODAIT/max-central-repo/blob/master/PULL_REQUEST_TEMPLATE.md

Done

We can point them from main page

1. This repo is dedicated to MAX. I am not sure if we are mixing MAX and DAX here. It is better to have separate as the structure will be different. I will initiate a conversation with Gabriela about the same.
   For now, can we just have MAX and not DAX?

Yes, I've updated the PR

xuhdev commented 4 years ago

@SSaishruthi Updated

SSaishruthi commented 4 years ago

Thanks @xuhdev

I have a few more suggestions. Why don't we just add this information under the contribution section of the main readme?

(We can also have in status.md if you think it will be useful)

Here: https://github.com/CODAIT/max-central-repo#contributing-to-the-model-asset-exchange

We can remove points under Code Change and Feature Request from PR template and add it here.

  1. To start a general discussion create an issue in this repo.
  2. If it is a model-specific issue, go to the corresponding repo. Either create an issue or PR with detailed explanation of the change (or whatever we want)

Let me know what you think

xuhdev commented 4 years ago

@SSaishruthi I've added some clarification in README. I don't think we should remove them in the template though, because from there we can hold a user's temptation upon opening an issue/PR in this repo.