search

CODAIT / nlp-editor

Visual Editor for Natural Language Processing pipelines
Apache License 2.0
15 stars 9 forks source link

Union execution shows results from one of the inputs, then fails #61

Closed laurachiticariu closed 2 years ago

laurachiticariu commented 2 years ago

This is likely a duplicate of https://github.com/CODAIT/nlp-editor/issues/54 but I could reproduce it today with the tutorial flow.

It can be reproduced with this flow. union_issue.json.txt

  1. Create a union node for RevenueOfDivision1 and RevenueOfDivision2.
  2. Run the union. Get results from one of the sequences, not the second sequence, and not the union.
  3. Run the union again - we get an exception.
  4. As the gif shows, running the sequences individually sometimes leads to the wrong results being shown. I.e., run RevenueOfDivision2 but get results from RevenueOfDivision1. union_defect
JesusGuerrero commented 2 years ago

@laurachiticariu I see the issue. The Union works when the two Sequence nodes' attributes are renamed to the name of the Union. For example, the Union is names RevenueOfDivision and both Sequences have their main output renamed to the same value. I will fix this so that the Union will yield to any name brought in by the Sequences