CODAIT / nlp-editor

Visual Editor for Natural Language Processing pipelines
Apache License 2.0
15 stars 9 forks source link

npm install does not work due to conflicting dependencies #80

Closed agiagoulas closed 1 year ago

agiagoulas commented 2 years ago

npm install only works when using npm i --force which cannot be correct

laurachiticariu commented 1 year ago

@agiagoulas is this still reproducible? If not, can you please close it?

IBMOlaf commented 1 year ago

@laurachiticariu @agiagoulas I cannot reproduce the issue - probably caused by not having used/selected the recommended node v14.17.6. With appropriate node version (nvm use v14.17.6) I just get the following warnings by executing npm install:

npm WARN @elyra/canvas@12.12.3 requires a peer of react@^16.0.0 but none is installed. You must install peer dependencies yourself. npm WARN @elyra/canvas@12.12.3 requires a peer of react-dom@^16.0.0 but none is installed. You must install peer dependencies yourself. npm WARN ajv-keywords@3.5.2 requires a peer of ajv@^6.9.1 but none is installed. You must install peer dependencies yourself. npm WARN react-codemirror2@7.2.1 requires a peer of react@>=15.5 <=16.x but none is installed. You must install peer dependencies yourself. npm WARN react-contextmenu@2.14.0 requires a peer of react@^0.14.0 || ^15.0.0 || ^16.0.1 but none is installed. You must install peer dependencies yourself. npm WARN react-contextmenu@2.14.0 requires a peer of react-dom@^0.14.0 || ^15.0.0 || ^16.0.1 but none is installed. You must install peer dependencies yourself. npm WARN react-resize-detector@5.2.0 requires a peer of react@^16.0.0 but none is installed. You must install peer dependencies yourself. npm WARN react-resize-detector@5.2.0 requires a peer of react-dom@^16.0.0 but none is installed. You must install peer dependencies yourself. npm WARN react-virtualized@9.22.3 requires a peer of react@^15.3.0 || ^16.0.0-alpha but none is installed. You must install peer dependencies yourself. npm WARN react-virtualized@9.22.3 requires a peer of react-dom@^15.3.0 || ^16.0.0-alpha but none is installed. You must install peer dependencies yourself.

Subsequent npm run build followed by npm run serve is working (nlp-editor running against the local IBM Watson Backend container)

So following the Readme.md description seems to work (checked on macOS Monterey - except one hint/question: should the Seer-Code mentioned under 2. in fact be Seer-Core?

SeerCode-vs-SeerCore

agiagoulas commented 1 year ago

Okay, I think then I can close the issue

laurachiticariu commented 1 year ago

Thanks @IBMOlaf we removed the step to create the directories (and yes, Seer-Code was a typo, thanks for pointing it out).