This reverts commit adee112345d05980b00591ee5b93e7e5df8a0cf1.
We should achieve by modifying load_dataset, not Dataset
Checklist:
- Does this pull request close an issue? We encourage you to open an issue first if this pull request (PR) is not a
minor change.
- [ ] No
- [ ] The change in this pull request is minor.
- [ ] Yes
- Close #{issue_number}
For the following questions, only check the boxes that are applicable.
- [ ] Ensure that the pull request text above the horizontal line is descriptive.
- [ ] Add/update relevant tests.
- [ ] Add/update relevant documents.
- Do you have triage permission of this repository?
- [ ] No
- You are good.
- [ ] Yes
- Does this pull request close an issue?
- [ ] No, this pull request also acts as an issue by itself.
- [ ] Assign yourself.
- [ ] Label this pull request.
- [ ] Put a milestone.
- [ ] Put this pull request under "In Progress" or "Under Review" pipeline on ZenHub.
- [ ] Put this pull request under the appropriate epic on ZenHub.
- [ ] Put an estimate on ZenHub.
- [ ] Add dependency relationship with other issues/pull requests on ZenHub.
- [ ] Yes, this pull request addresses an issue and does not act as an issue.
- [ ] Connect this pull request to the underlying issue on ZenHub.
- [ ] DON'T:
- DON'T assign yourself or anyone else.
- DON'T label.
- DON'T put a milestone.
- DON'T put this pull request under any epic on ZenHub.
- DON'T put an estimate on ZenHub.
- [ ] When the pull request is ready, request review.
This reverts commit adee112345d05980b00591ee5b93e7e5df8a0cf1.
We should achieve by modifying
load_dataset, notDatasetChecklist:
- Does this pull request close an issue? We encourage you to open an issue first if this pull request (PR) is not a minor change. - [ ] No - [ ] The change in this pull request is minor. - [ ] Yes - Close #{issue_number} For the following questions, only check the boxes that are applicable. - [ ] Ensure that the pull request text above the horizontal line is descriptive. - [ ] Add/update relevant tests. - [ ] Add/update relevant documents. - Do you have triage permission of this repository? - [ ] No - You are good. - [ ] Yes - Does this pull request close an issue? - [ ] No, this pull request also acts as an issue by itself. - [ ] Assign yourself. - [ ] Label this pull request. - [ ] Put a milestone. - [ ] Put this pull request under "In Progress" or "Under Review" pipeline on ZenHub. - [ ] Put this pull request under the appropriate epic on ZenHub. - [ ] Put an estimate on ZenHub. - [ ] Add dependency relationship with other issues/pull requests on ZenHub. - [ ] Yes, this pull request addresses an issue and does not act as an issue. - [ ] Connect this pull request to the underlying issue on ZenHub. - [ ] DON'T: - DON'T assign yourself or anyone else. - DON'T label. - DON'T put a milestone. - DON'T put this pull request under any epic on ZenHub. - DON'T put an estimate on ZenHub. - [ ] When the pull request is ready, request review.