Closed iyounus closed 7 years ago
Build triggered.
Build success. All unit tests passed.
Build triggered.
Build success. All unit tests passed.
@adrian555 can we test it just manually starting the session using enableHive... = FALSE and make sure there is not metastore dir created? I think i can't see any other way of doing it what do you think? please let us know
Build triggered.
I just added another test for enableHiveSupport. The first test I added was to just have any test for zzz, and then plan was to add more tests in the future, because no tests existed for r4ml.session. For enableHiveSupport, sparkR adds spark.sql.catalogImplementation to config and set it to "hive". When we disable hive support, this variable no longer exists in the config. So, I've added a test accordingly.
Build success. All unit tests passed.
Build triggered.
Build success. All unit tests passed.
This PR adds the ability to pass on arguments from r4ml.session to sparkr.session. This will allow user to set enableHiveSupport = FALSE. BTW, for sparkr.session, the defaults is enableHiveSupport = TRUE.
Developer's Certificate of Origin 1.1