CODAIT / r4ml

Scalable R for Machine Learning
Apache License 2.0
42 stars 13 forks source link

[MINOR]remove deprecated attribute representation #39

Closed hungple closed 7 years ago

hungple commented 7 years ago

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.
R4ML-CI commented 7 years ago

Can one of the admins verify this patch?

hungple commented 7 years ago

I have removed deprecated attribute "representation", and used "slots" instead.

bdwyer2 commented 7 years ago

Jenkins, ok to test Jenkins, add to whitelist

R4ML-CI commented 7 years ago

Build triggered.

bdwyer2 commented 7 years ago

@hungple looks good thanks!

Do you think you could also fix the spelling of "pacakge" in README.md with this PR?

R4ML-CI commented 7 years ago

Build success. All unit tests passed.

hungple commented 7 years ago

@bdwyer2 I have fixed the spelling of "pacakge" in README.md and 2 other files.

R4ML-CI commented 7 years ago

Build triggered.

R4ML-CI commented 7 years ago

Build success. All unit tests passed.