Closed BryanCutler closed 4 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
I still need to fill in some parts, but could use a review of this so far. cc @frreiss @MLnick @kmh4321
This is looking great! A few minor corrections inline.
@frreiss I filled in the rest of this notebook and addressed your feedback, please take another look - thanks! Also cc @kmh4321 , maybe you could take a quick look as someone newer to the project and see if everything is clear?
Sure, I'll also take a look.
On Fri, Sep 25, 2020, 4:58 PM Bryan Cutler notifications@github.com wrote:
@frreiss https://github.com/frreiss I filled in the rest of this notebook and addressed your feedback, please take another look - thanks! Also cc @kmh4321 https://github.com/kmh4321 , maybe you could take a quick look as someone newer to the project and see if everything is clear?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CODAIT/text-extensions-for-pandas/pull/122#issuecomment-699227732, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH24Y4GDV4655DYOKPWFV33SHUVC5ANCNFSM4RRHCF4Q .
The current version of this notebook looks good to me. Have you had a chance to review it, @kmh4321 ?
Thanks @frreiss and @kmh4321 , good suggestions! I'll update again tonight and merge when done, we can fine tune more later if needed.
This adds a notebook to show the basics and give an overview of Text Extensions for Pandas, and serve as a jumping off point to other notebooks.