search

CODAIT / text-extensions-for-pandas

Natural language processing support for Pandas dataframes.
Apache License 2.0
217 stars 34 forks source link

Fixes for Python 3.6 #128

Closed BryanCutler closed 4 years ago

BryanCutler commented 4 years ago

Fixed imports causing problems with Python 3.6. Import in the form of import text_extensions_for_pandas.io.bert as bert end up causing a circular reference due to later imports also referencing io which has not been initialized yet. Using the form from text_extensions_for_pandas.io import bert avoid this.

BryanCutler commented 4 years ago

cc @kmh4321 @frreiss

BryanCutler commented 4 years ago

Great, thanks for checking @kmh4321 . This also adds Python 3.6 to travis CI to make sure we don't break the imports again. I'll go ahead and merge.

frreiss commented 4 years ago

LGTM. I notice that this change set leaves env.sh unchanged, which means we will be developing with Python 3.7. I think that's ok for now, since Travis will be testing with 3.6.