search

CODAIT / text-extensions-for-pandas

Natural language processing support for Pandas dataframes.
Apache License 2.0
217 stars 34 forks source link

Fix TensorArray.isna() to handle types other than numeric #133

Closed BryanCutler closed 4 years ago

BryanCutler commented 4 years ago

TensorArray.isna() used numpy functions only for numeric types. This change adds checks for numpy objects and strings.

Fixes #132

BryanCutler commented 4 years ago

The failure is coming from Pandas 1.0.5 because the GenericFormatter, that handles strings and objects, messes up with values with dims > 1. This was fixed in Pandas 1.1, and I don't see a way around it other than bumping up the minimum pandas version. I'll look again tomorrow.