search

CODARcode / Example-Heat_Transfer

3 stars 3 forks source link

segfault if stage_write has wrong parameters #2

Closed bd4 closed 7 years ago

bd4 commented 7 years ago

Running stage_write/stage_write heat.pb staged.pb FLEXPATH MPI 2 causes a segfault. This is being triggered by a Cheetah bug that is loosing the empty parameters after FLEXPATH and MPI, but a better error messages for cases like this would be very helpful in debugging.

jychoi-hpc commented 7 years ago

Updated a line to check the minimum number of parameters in "stage_write". It simply check the number of parameters. If there are more complicated scenarios, we need to consider to use more sophisticated routines. Please let us know if this is enough at this moment.

bd4 commented 7 years ago

Thanks, that is a ood short term solution, nothing more is needed short term. I do think deeper error checking would be good to add later though.