CODARcode / Example-Heat_Transfer

3 stars 3 forks source link

DATASPACES, etc. #9

Open ianfoster opened 7 years ago

ianfoster commented 7 years ago

It is confusing that one has to edit heat_transfer.xml to use DATASPACES. Can we get rid of that requirement?

mw70 commented 7 years ago

That's a fundamental feature of Adios. The specification of the service you want to use is separate from what is compiled into the code. That said, there are ways we could change it as an initial example, though -- either by updating the launch script so that it makes the change for you, or by changing the executable to hardwire specific choices in.

Thoughts? Is it better to write a little more text to explain the Adios rationale for the editing? Or make it easy to do the initial launch?

Matthew


From: Ian Foster notifications@github.com Date: July 18, 2017 at 11:56:06 PM EDT To: CODARcode/Example-Heat_Transfer Example-Heat_Transfer@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [CODARcode/Example-Heat_Transfer] DATASPACES, etc. (#9)

It is confusing that one has to edit heat_transfer.xml to use DATASPACES. Can we get rid of that requirement?

- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/CODARcode/Example-Heat_Transfer/issues/9, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADffmuHs4sQukV-LZaFxUfURiTnNBq_aks5sPX5QgaJpZM4OcMve.

jychoi-hpc commented 7 years ago

I think making easy for initial launch would be good. stage_write already takes Adios methods as command line parameters, without using XML file. We can change heat_transfer to have the same feature.

ianfoster commented 7 years ago

Matthew, I am not sure that this is the ADIOS issue that you raise, unless I am misunderstanding. My concern is that I need to edit heat_transfer.xml as well as pass the "DATASPACES" (or MPI or FLEXPATH) parameter to workflow.swift. I want to just do the latter.

mw70 commented 7 years ago

My point was that modifying the xml file is inherent in ADIOS. You're certainly correct that we can make a script do that for us instead... I know how to do that with sed in a bash script, but I'd have to puzzle through how best to do that from inside workflow.swift. Or, as Jong says, we just programmatically force heat_transfer to use whatever is supplied to the command line.