CODARcode / MGARD

MGARD: MultiGrid Adaptive Reduction of Data
Apache License 2.0
37 stars 25 forks source link

Various fixes for CMake and MGARD #141

Closed robertu94 closed 3 years ago

robertu94 commented 3 years ago

@ben-e-whitney

ben-e-whitney commented 3 years ago

Hi @robertu94. Thank you for the changes, and apologies for the delay. I've learned a lot reading about pkg-config.

I rebased and fixed one small merge conflict. I then changed the build workflow so that MOAB will be compiled with -fPIC (needed to make libmgard shared, I think). This should fix the failing check. The check did fail again after I pushed that commit (bcb9e065c37f2daeae1f71ca8f7d46b6f17a06b0), but I believe that's because the runner fetched the MOAB library from the cache rather than recompiling. @qliu21, you can accept this now. I'll fix the -fPIC issue if it persists.