Race condition in Majora add MAG

COG-UK / dipi-group

Data integrity and pipeline integration working group

4 stars 1 forks source link

Race condition in Majora add MAG #183

Closed SamStudio8 closed 2 years ago

SamStudio8 commented 2 years ago

Ocarina step was disrupted this morning by a rare race condition adding a DigitalResourceGroup. This is the first time this has happened so I'll monitor the situation before taking action. Relevant code here: https://github.com/SamStudio8/majora/blob/stable/majora2/form_handlers.py#L279. Everything running fine now.

SamStudio8 commented 2 years ago

Solving this properly is going to need a patch in Majora which I'm not keen to rush out on a Friday. We might be able to get away with pushing a single post-Elan, pre-Ocarina placeholder artifact to force the DigitalArtifactGroups to be created before calling the Ocarina pipeline.

SamStudio8 commented 2 years ago

Fixed for now by https://github.com/SamStudio8/elan-nextflow/commit/45ae743704ed504165444076b59332bf3f934c0e