COMBINE-lab / RapMap

Rapid sensitive and accurate read mapping via quasi-mapping
GNU General Public License v3.0
89 stars 23 forks source link

Fixing problems with no mappings #11

Closed vals closed 8 years ago

vals commented 8 years ago

Whenever a batch of 1,000 reads had 0 mappings, pop_back() caused a segmentation fault, probably because the string is empty.

Additionally, when this happens a new empty line was output for each group of empty reads, causing samtools to fail.

(By the way, having no read among 1,000 to map anywhere is a very rare event.)

rob-p commented 8 years ago

Thanks @vals --- there's all kinds of good corner cases that show up with single-cell data. Thanks for the bug report and the fix!