COMBINE-lab / matryoshka

Methods for the automated discovery of hierarchically-structured chromatin domains
5 stars 1 forks source link

Segfault #1

Closed robinweide closed 8 years ago

robinweide commented 8 years ago

Hi there,

I read your paper with great interest and would like to try your tool.

Using boost from Homebrew, I compiled your code per your instructions. However, I get a Segmentation fault 11 at different times, when changing the size of the matrix. Even very small matrices seem to cause a Segfault11.

Could you please help?

Thanks,

Robin


Specs:

laraib85 commented 8 years ago

Hi,

Thanks for your interest in the tool. Could you send me the file you're trying to run the tool on? I'll look into the issue.

robinweide commented 8 years ago

Awesome! I just used your example-matrix and sub-samples of it.

rob-p commented 8 years ago

@laraib85 --- such segfaults are usually the result of trying to access an array out of bounds somewhere (which has undefined behavior and thus makes reproducing things difficult). We might try adding -D _GLIBCXX_DEBUG to the compiler flags to turn on bounds checking for all vector accesses to see if that helps us catch it.

laraib85 commented 8 years ago

@robinweide hey, try running it now. Fixed the bug, should be fine. Thanks!

robinweide commented 8 years ago

Tried installing it on my Mac with the following error (will try on my Ubuntu-desktop tomorrow):

[ 20%] Building CXX object src/CMakeFiles/matryoshka.dir/Matryoshka.cpp.o cd /Users/robin/bin/matryoshka-master/src && /Users/robin/bin/matryoshka-master/clang++ -O3 -g -std=c++11 -Wall -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -mmacosx-version-min=10.9 -I/Users/robin/boost/include -I/Users/robin/bin/matryoshka-master/include -o CMakeFiles/matryoshka.dir/Matryoshka.cpp.o -c /Users/robin/bin/matryoshka-master/src/Matryoshka.cpp /bin/sh: /Users/robin/bin/matryoshka-master/clang++: No such file or directory make[2]: * [src/CMakeFiles/matryoshka.dir/Matryoshka.cpp.o] Error 127 make[1]: * [src/CMakeFiles/matryoshka.dir/all] Error 2 make: *\ [all] Error 2

laraib85 commented 8 years ago

I didn't make any changes to the make files so it should compile as before. It can't find clang. Make sure the program can access the correct folder where clang is installed.

rob-p commented 8 years ago

Yes; this looks like a failure to find the compiler. Strangely, it seems it's looking for it in the matryoshka directory! @robinweide --- can you post the output of the command $ clang++ -v, and also $ which clang++? I would recommend completely removing the build directory and trying to make again from scratch. This build compiles cleanly on my macbook pro with clang version Apple LLVM version 7.0.2 (clang-700.1.81).

robinweide commented 8 years ago

Got it to compile on my desktop with:

cmake -DMAKE_C_COMPILER=/usr/bin/clang -DMAKE_CXX_COMPILER=/usr/bin/clang++ -DBOOST_ROOT=$HOME/boost -DBOOST_NO_SYSTEM_PATHS=true

Thanks everybody! :+1: