search

COMBINE-lab / quark

semi-reference-based short read compression
GNU General Public License v3.0
11 stars 5 forks source link

sailfish dependency #3

Closed dcjones closed 7 years ago

dcjones commented 7 years ago

quark.sh depends on having $sailfish set, but the readme doesn't note having to set this, or even that sailfish is required. Worth mentioning somewhere!

hiraksarkar commented 7 years ago

Hi,

Thanks for pointing this out. Quark is built on the top of sailfish. So it uses the framework, but it does not explicitly use sailfish. I forgot to change the binary name in quark.sh. It is fixed now with the latest commit 390c4f88102916575e6ec700171eb25159338b3d. Please let me know if that fixes the sailfish dependency.

dcjones commented 7 years ago

Yeah, that's better :+1: