Open connersk opened 3 months ago
Following up on this, if I was to fork salmon
and fix this, would the correct solution be to update the following line? https://github.com/COMBINE-lab/salmon/blob/a2f6912b3f9f9af91e3a4b0d74adcb3bdc4c9a32/src/AlevinUtils.cpp#L1204
tl;dr
salmon alevin
returns an error if the cell barcode length is > 31 base pairssalmon alevin
for a novel scRNA-seq chemistry that has a 34 base pair cell barcode.salmon alevin
maximum cell barcode length was increased from 20 base pairs to 31 base pairs. https://github.com/COMBINE-lab/salmon/discussions/629Summary
This bug primarily related to alevin (single-cell mode).
Describe the bug
To Reproduce
Steps and data to reproduce the behavior:
Specifically, please provide at least the following information:
v1.10.1
Expected behavior Salmon alevin does not error out when the cell barcode length is 34 base pairs.
Screenshots Error log
[2024-06-17 22:00:25.466] [alevinLog] [error] Barcode length (34) was not in the required length range [1, 31].
Desktop (please complete the following information):