fix: write workflow log when external command fails

COMBINE-lab / simpleaf

A rust framework to make using alevin-fry even simpler

BSD 3-Clause "New" or "Revised" License

41 stars 3 forks source link

fix: write workflow log when external command fails #108

Closed DongzeHE closed 8 months ago

DongzeHE commented 9 months ago

Thanks to #107

rob-p commented 8 months ago

Hi @DongzeHE,

Can you explain the purpose of this PR a bit more? It's not immediately clear to me what's going on in the changes.

DongzeHE commented 8 months ago

I am sorry! The thing is when I was debugging that issue, we found that when simpleaf workflow quit after an external command failed, it did not write the log files out. Upon checking, this was because we forgot to call the function for writing out the files in this case. In this PR, I added the function call correspondingly to fix this problem.

Best, Dongze