Closed vaitkus closed 1 year ago
I think I added that (?). I can't remember why; I think because I saw it somewhere else, but I can't find where I did.
I'll try harder, and if I can't, the solution would be to remove it from the DDLm version.
I didn't add it; it's there in the very first commit.
Any input @jamesrhester ?
I do know that '%' breaks the autohtml linking on the IUCr website
No particular comment, it shouldn't be there if no such data name was ever defined.
The
_pd_phase_mass.percent
data item defines_pd_phase_mass_percent
as one of its aliases. However, the DDL1 version of the PD dictionary [1] does not define this dotless variation of the name, only_pd_phase_mass_%
. While an additional alias is not at all harmful it is also not serve an archival purpose like the rest of the aliases. Which of these two is the preferred approach:_pd_phase_mass_percent
from the DDLm version._pd_phase_mass_percent
to the DDL1 version.[1] https://github.com/COMCIFS/DDL1-legacy-dictionaries/blob/master/dictionaries/cif_pd.dic