search

COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

_pd_phase_mass.percent: the _pd_phase_mass_percent alias is not needed #103

Closed vaitkus closed 1 year ago

vaitkus commented 1 year ago

The _pd_phase_mass.percent data item defines _pd_phase_mass_percent as one of its aliases. However, the DDL1 version of the PD dictionary [1] does not define this dotless variation of the name, only _pd_phase_mass_%. While an additional alias is not at all harmful it is also not serve an archival purpose like the rest of the aliases. Which of these two is the preferred approach:

  1. Remove _pd_phase_mass_percent from the DDLm version.
  2. Add _pd_phase_mass_percent to the DDL1 version.

[1] https://github.com/COMCIFS/DDL1-legacy-dictionaries/blob/master/dictionaries/cif_pd.dic

rowlesmr commented 1 year ago

I think I added that (?). I can't remember why; I think because I saw it somewhere else, but I can't find where I did.

I'll try harder, and if I can't, the solution would be to remove it from the DDLm version.

rowlesmr commented 1 year ago

I didn't add it; it's there in the very first commit.

Any input @jamesrhester ?

I do know that '%' breaks the autohtml linking on the IUCr website

jamesrhester commented 1 year ago

No particular comment, it shouldn't be there if no such data name was ever defined.