search

COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

replace markup with unicode characters #123

Closed rowlesmr closed 1 year ago

rowlesmr commented 1 year ago

and fixed formatting of some equations

Just an experiment to see if it works.

publcif commented 1 year ago

Yeah, full CIF2! I suppose the question is - should the style policy for these ddlm dictionaries prefer use of unicode rather than semantic escape sequences, at least in descriptive text? I guess it would need some careful editing of existing CIF1 text (I note that you've had to fix some errors e.g. change \q to θ as well as \q, and have also changed words such as 'lambda' and 'theta' to their unicode symbols)...

publcif commented 1 year ago

Correction: I meant change \\q to θ

rowlesmr commented 1 year ago

This is why I did it here first (in a little dictionary :) ) to see how it works, and what else needs to be changed.

rowlesmr commented 1 year ago

I think there may be a uinicode-related bug in the layout check, cf https://github.com/COMCIFS/cif_core/issues/414 and https://github.com/COMCIFS/cif_core/issues/413

rowlesmr commented 1 year ago

should the style policy for these ddlm dictionaries prefer use of unicode rather than semantic escape sequences, at least in descriptive text?

Personal opinion: Be conservative here. Descriptive text, yes. Datavalues, no.

eg the value of _pd_background.x_coordinate can be 2theta, but not 2θ

jamesrhester commented 1 year ago

Need to wait for @nautolycus to comment re Vol G workflow. Following release of next edition we can change the descriptive text to unicode for sure.

rowlesmr commented 1 year ago

From @nautolycus over here: https://github.com/COMCIFS/cif_core/pull/413#issuecomment-1576477352

Wait, out.

rowlesmr commented 1 year ago

From @nautolycus over here: COMCIFS/cif_core#413 (comment)

Wait, out.

Go for it: https://github.com/COMCIFS/cif_core/pull/413#issuecomment-1593107753 and https://github.com/COMCIFS/cif_core/pull/413