COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

Adding category examples #124

Open rowlesmr opened 1 year ago

rowlesmr commented 1 year ago

Adding examples of use at the category level.

Not updating update dates yet.

Categories:

Not (currently) going to, as other categories are taking over, or have taken over:

rowlesmr commented 1 year ago

I don't think that _pd_calib_detected_intensity.id is a necessary category key, but also:

Apart from that I think including an identifier data name in the key is fine, e.g. you just keep calibrating the instrument every week and assign an identifier to each calibration https://github.com/COMCIFS/Powder_Dictionary/pull/92#issuecomment-1493593082

rowlesmr commented 1 year ago

I don't think that _pd_calib_detected_intensity.id is a necessary category key, but also:

Apart from that I think including an identifier data name in the key is fine, e.g. you just keep calibrating the instrument every week and assign an identifier to each calibration #92 (comment)

I think we should keep _pd_calib_detected_intensity.id (due to being able to record multiple calibrations on the same instrument over time*), but I am now unsure that _pd_calib_detected_intensity.diffractogram_id is doing it's job.

If I have

data_unknown_diffractogram
_pd_diffractogram.id UNKNOWN_SPECIMEN

loop_
_pd_calib_detected_intensity.id
_pd_calib_detected_intensity.detector_id
_pd_calib_detected_intensity.detector_response
_pd_calib_detected_intensity.special_details
1   1_4913c6ed   1       'Scanned through direct beam.'
1   2_4913c6ed   0.973   'Scanned through direct beam.'
1   3_4913c6ed   0.997   'Scanned through direct beam.'
1   4_4913c6ed   1.039   'Scanned through direct beam.'
#...

then _pd_calib_detected_intensity.diffractogram_id gets the value 'UNKNOWN_SPECIMEN', when the intention is to record the diffractogram which was used to make the calibration, if such a diffractogram exists (which doesn't, in this case).

I think this ties in to #163.

This whole argument also applies to _pd_calib_incident_intensity.diffractogram_id

* I need to add a key to PD_CALIB_INCIDENT_INTENSITY.