Closed rowlesmr closed 1 year ago
The failed check is due to the category deprecations. The checks can't find the replacement category.
The _definition_replaced.by
attribute is not meant for categories, only for data items.
The information about category deprecation and replaced can be recorded in the description as a human-readable text (as is currently done).
Ah. I must have misunderstood James' answer previously.
Will change.
I think PD_CALIBRATION
should stay and be updated. See #133.
Originally talked about in #53 and implemented in #89, #91, #92, and #93
The new categories
PD_CALIB_DETECTED_INTENSITY
PD_CALIB_INCIDENT_INTENSITY
PD_CALIB_WAVELENGTH
PD_CALIB_XCOORD
PD_QPA_INTERNAL_STD
take up the functionality previously facilitated by
PD_CALIB
PD_CALIB_OFFSET
PD_CALIB_STD
This PR is to deprecate redundant data items and categories.
.
I'm not deprecating
PD_CALIBRATION
yet, as I need to convince myself how I can calibrate a (for instance) energy-sensitive detector based on detector_id to energy (or position, or 2th or whatever...)