COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

Deprecate calibration categories #132

Closed rowlesmr closed 1 year ago

rowlesmr commented 1 year ago

Originally talked about in #53 and implemented in #89, #91, #92, and #93

The new categories

take up the functionality previously facilitated by

This PR is to deprecate redundant data items and categories.

.

I'm not deprecating PD_CALIBRATION yet, as I need to convince myself how I can calibrate a (for instance) energy-sensitive detector based on detector_id to energy (or position, or 2th or whatever...)

rowlesmr commented 1 year ago

The failed check is due to the category deprecations. The checks can't find the replacement category.

vaitkus commented 1 year ago

The _definition_replaced.by attribute is not meant for categories, only for data items.

The information about category deprecation and replaced can be recorded in the description as a human-readable text (as is currently done).

rowlesmr commented 1 year ago

Ah. I must have misunderstood James' answer previously.

Will change.

rowlesmr commented 1 year ago

I think PD_CALIBRATION should stay and be updated. See #133.