COMCIFS / Powder_Dictionary

CIF definitions for powder diffraction
4 stars 4 forks source link

Update `PD_CALIBRATION` #133

Open rowlesmr opened 1 year ago

rowlesmr commented 1 year ago

I think PD_CALIBRATION should stay, but be updated a bit.

The pupose of PD_CALIBRATION is to provide a free-text method of stating the equation used to convert between channel or position and 2\q/E/d/TOF/whatever. Given free-reign to rename it, it would probably be PD_CALIB_XCOORD_EQUATION, but that's (I think) an unnecessary complication.

It isn't necessary to be machine-readable, as you can just give the conversion directly in the data listing, as

loop_
_pd_data.id
_pd_meas.detector_id  # could also be _pd_meas.position
_pd_proc.energy_detection
_pd_meas.counts_total
a   1    50000    1234
b   2    50100    1434
c   3    50200    1457
#...

From the given data, the conversion is given on a on-to-one basis.

.

The category currently consists of

The category delegates the task of recording the source of the calibration information to _pd_calib_std.external_block_id.

I would expand the category by adding

briantoby commented 1 year ago

I think that that it was intended to describe how one did calibration as well.

Reply to this email directly, view it on GitHubhttps://github.com/COMCIFS/Powder_Dictionary/issues/133, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACH7E2D6W27YSAGLTVJJMWTXJ3YSBANCNFSM6AAAAAAY4DT3CI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

rowlesmr commented 1 year ago

Yes. special_details is there to capture how the instrument was calibrated, as well as other information that is pertinent to the calibration, such as hardware and software changes that are then transparent to the experiment.